Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci scripts for windows #251

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Add ci scripts for windows #251

merged 9 commits into from
Sep 26, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Jul 20, 2023 •
edited by jrhemstad
Loading

This adds ci scripts for windows that are derived from our linux build scripts and should work similarly

contributes to #248

@miscco miscco requested review from a team as code owners July 20, 2023 12:50
@miscco miscco requested review from jarmak-nv, alliepiper, wmaxey, a team, ericniebler and jrhemstad and removed request for a team July 20, 2023 12:50
@miscco

This comment was marked as resolved.

Sign in to view
@miscco

This comment was marked as outdated.

Sign in to view
jrhemstad
jrhemstad reviewed Jul 20, 2023
View reviewed changes
_deps/catch2-src Outdated Show resolved Hide resolved
@miscco

This comment was marked as resolved.

Sign in to view
@jrhemstad jrhemstad mentioned this pull request Jul 20, 2023
Closed
1 task
@robertmaynard

This comment was marked as resolved.

Sign in to view
@miscco
Copy link
Collaborator Author

miscco commented Jul 20, 2023 •
edited
Loading

Given that it also can't find the cublas_v2.h header under include, I would verify that the CUDA Toolkit libraries are actually installed, and this wasn't a minimal compiler only install.

We are installing via the network installer by issueing:

Start-Process -Wait -PassThru -FilePath .\cuda_network.exe -ArgumentList "-s nvcc_${componentTag} cudart_${componentTag}"

I thought that by adding ``cudart_${componentTag}` it would include the runtime

EDIT: According to https://docs.nvidia.com/cuda/cuda-installation-guide-microsoft-windows/index.html it is indeed not sufficient

@miscco
Copy link
Collaborator Author

miscco commented Jul 20, 2023

I added curand and cublas to the CTK components installed That should get cub building

@miscco miscco force-pushed the msvc_ci branch 3 times, most recently from 4fe18c1 to cbbd1ab Compare July 21, 2023 07:37
@miscco
Copy link
Collaborator Author

miscco commented Jul 21, 2023

I got all projects to finally compile 🎉

@miscco miscco requested a review from jrhemstad July 21, 2023 07:43
@miscco miscco added feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure labels Jul 24, 2023
@miscco miscco force-pushed the msvc_ci branch 2 times, most recently from 627b797 to 7749a7d Compare September 22, 2023 08:14
@miscco
[skip-tests] Add ci scripts for windows
319cb0d
@miscco
[skip-tests] Prepare testing with sccache
dfa8ad6 
sccache currently does not support the `-v` flag on MSVC. Also we cannot use it to test for supported compile flags as it will just break.

Finally on windows we want to compile with `--use-local-env` to avoid nvcc setting up the environment every time
@miscco
[skip-tests] Simplify the test workflow and add a windows run
83e5c27
@miscco
[skip-tests] For now replace sccache binary with custom one to get it…
2a2dd91 
… to work with MSVC
@wmaxey
Copy link
Member

wmaxey commented Sep 22, 2023

I'm seeing this, did something get reverted in the changes to make CUB able to ignore curand missing?

CUDA::curand

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

wmaxey
wmaxey reviewed Sep 22, 2023
View reviewed changes
ci/matrix.yaml Outdated Show resolved Hide resolved
@wmaxey
Copy link
Member

wmaxey commented Sep 22, 2023

This has my approval once CI is green.

@jrhemstad
Copy link
Collaborator

I think the curand not found error is because this PR updates to the 23.10 devcontainer images and @trxcllnt made some changes to slim down our images by removing some of the CTK libs. Looks like cuRand was inadvertently removed for CCCL's images.

@miscco
Copy link
Collaborator Author

miscco commented Sep 25, 2023

I have removed RDC support for now. I believe it would be better to merge this as is an fix RDC support in a followup PR.

@jrhemstad what do you think?

@miscco
Copy link
Collaborator Author

miscco commented Sep 25, 2023

I have opened rapidsai/devcontainers#153 for the missing curand dependency

@miscco miscco merged commit 1ce614e into NVIDIA:main Sep 26, 2023
499 checks passed
@jrhemstad jrhemstad mentioned this pull request Oct 5, 2023
Open
1 task
@jrhemstad jrhemstad linked an issue Oct 5, 2023 that may be closed by this pull request
Setup Windows runners #54
Closed
This was referenced Oct 5, 2023
Closed
Closed
@miscco miscco deleted the msvc_ci branch June 17, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@jarmak-nv jarmak-nv Awaiting requested review from jarmak-nv jarmak-nv is a code owner automatically assigned from NVIDIA/cccl-infra-codeowners

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

@wmaxey wmaxey Awaiting requested review from wmaxey

Assignees

@miscco miscco

Labels
feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Windows runners
5 participants
@miscco @robertmaynard @jrhemstad @wmaxey @elstehle